Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiled: fix crash from colliders #812

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

InnocentusLime
Copy link
Contributor

@InnocentusLime InnocentusLime commented Sep 17, 2024

This PR fixes closes #701. This described crash happened, because macroquad-tiled was using a duplicate empty Layer struct for Tile's objectgroup field.

Simply removing that duplicate type and importing the correct one from layer.rs makes the map successfully parse. It also seems that all the required fields for reading colliders are already present.

This change is backwards compatible as it only "adds" stuff, not removing anything.

@InnocentusLime InnocentusLime changed the title Remove duplicate Layer type tiled: fix crash from colliders Sep 17, 2024
@not-fl3 not-fl3 merged commit ad4d7cf into not-fl3:master Sep 17, 2024
6 checks passed
@InnocentusLime InnocentusLime deleted the fix-collider-issue branch September 17, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Tiled collisions in macroquad-tiled
2 participants